refactor(forms): hide adapter in public options#67249
refactor(forms): hide adapter in public options#67249kirjs wants to merge 1 commit intoangular:mainfrom
Conversation
Moves adapter to internal options to prevent exposure but keep compatibility.
There was a problem hiding this comment.
You'll want to update the public API.
Oh interesting, adapter currently isn't listed on FormOptions in the API: https://angular.dev/api/forms/signals/FormOptions
Is that because it's type wasn't exported?
Edit again: I linked the wrong thing. angular.dev does include the adapter, but our goldens do not: https://github.com/angular/angular/blob/main/goldens/public-api/forms/signals/index.api.md.
Edit^3: I forgot because we've been targeting minor instead of patch, that the live API docs are out of date: https://next.angular.dev/api/forms/signals/FormOptions#
|
|
||
| export function form<TModel>(...args: any[]): FieldTree<TModel> { | ||
| const [model, schema, options] = normalizeFormArgs<TModel>(args); | ||
| const [model, schema, options] = normalizeFormArgs< |
There was a problem hiding this comment.
normalizeFormArgs isn't a public API, so rather than generalizing it, can we just bake the FormAdapter into it's return type?
Moves adapter to internal options to prevent exposure but keep compatibility.