feat(forms): support binding number|null to <input type="text">#67268
Open
alxhub wants to merge 1 commit intoangular:mainfrom
Open
feat(forms): support binding number|null to <input type="text">#67268alxhub wants to merge 1 commit intoangular:mainfrom
number|null to <input type="text">#67268alxhub wants to merge 1 commit intoangular:mainfrom
Conversation
`<input type="number">` often does not provide the desired user experience when editing numbers in a form. MDN even [describes](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/number#using_number_inputs) how text inputs should be used in many cases instead, via `<input type="text" inputmode="numeric">` or similar configurations. Previously, this did not work with Signal Forms without a custom input component/directive. This PR builds support for binding `number|null` models directly to `<input type="text">` native controls via `[formField]`. When a model has a number or `null` value, signal forms will preserve that status when the user makes edits/changes. Empty string values are converted to `null`, other values are parsed as numbers, and a parse error is raised when a non-numeric value is entered. Note that it's up to the UI developer to configure additional UI affordances such as setting an appropriate `inputmode`, rejecting non-numeric keypresses, etc. Fixes angular#66903 Fixes angular#66157
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<input type="number">often does not provide the desired user experience when editing numbers in a form. MDN even describes how text inputs should be used in many cases instead, via<input type="text" inputmode="numeric">or similar configurations. Previously, this did not work with Signal Forms without a custom input component/directive.This PR builds support for binding
number|nullmodels directly to<input type="text">native controls via[formField]. When a model has a number ornullvalue, signal forms will preserve that status when the user makes edits/changes. Empty string values are converted tonull, other values are parsed as numbers, and a parse error is raised when a non-numeric value is entered.Note that it's up to the UI developer to configure additional UI affordances such as setting an appropriate
inputmode, rejecting non-numeric keypresses, etc.Fixes #66903
Fixes #66157