docs(docs-infra): scroll home features section into view on tab change#67282
Conversation
| enum FeatureTab { | ||
| Signals = 'signals', | ||
| ControlFlow = 'control-flow', | ||
| DeferrableViews = 'deferrable-views', | ||
| Hydration = 'hydration', | ||
| } |
There was a problem hiding this comment.
Added an enum since the IDs are now used in the class as well.
There was a problem hiding this comment.
Can we make that a const object instead ? (the js generated is unecessary verbose)
| export default class Home { | ||
| private readonly activatedRoute = inject(ActivatedRoute); | ||
| protected readonly isUwu = 'uwu' in this.activatedRoute.snapshot.queryParams; | ||
| private readonly codeHighlighter = inject(CodeHighligher); |
|
Deployed adev-preview for 61ea6f4 to: https://ng-dev-previews-fw--pr-angular-angular-67282-adev-prev-sy1kcqev.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
A small UX improvement where the Features section on the home page is scrolled into view when you change the feature tab.
c764ad7 to
61ea6f4
Compare
|
For some reason, this change breaks the section in Safari. Looking into it ... |
|
It seems that the issue is reproducible on |
|
Looks like this can't land in patch. Switching to RC. |
|
Oh wow...it can't land in RC either. We'll need a patch PR if you want this to land in anything but main. |
|
This PR was merged into the repository. The changes were merged into the following branches:
|
A small UX improvement where the Features section on the home page is scrolled into view when you change the feature tab.
If you happen to randomly explore the page and click on the various buttons, in the case of the features tabs and depending on your screen size, the actual action happens outside of the viewport.