test(forms): cover transformedValue without FormField context#67325
Open
sonukapoor wants to merge 1 commit intoangular:mainfrom
Open
test(forms): cover transformedValue without FormField context#67325sonukapoor wants to merge 1 commit intoangular:mainfrom
sonukapoor wants to merge 1 commit intoangular:mainfrom
Conversation
Adds a test verifying that `transformedValue` exposes parse errors via the returned signal's `parseErrors()` property when no FormField context is present. This ensures that: - parse errors are still observable without DI-based field propagation - the model is not updated when `parse` omits `value` - valid input clears parse errors and updates the model This test protects the documented contract that DI-based error propagation is expected for FormValueControl usage, while standalone usage relies on explicit consumption of `parseErrors()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test verifying that
transformedValueexposes parse errors via the returned signal'sparseErrors()property when no FormField context is present.This ensures that:
parseomitsvalueThis test protects the documented contract that DI-based error propagation is expected for FormValueControl usage, while standalone usage relies on explicit consumption of
parseErrors().PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information