fix(core): ensure custom controls resolve host directives#67329
Open
alxhub wants to merge 2 commits intoangular:mainfrom
Open
fix(core): ensure custom controls resolve host directives#67329alxhub wants to merge 2 commits intoangular:mainfrom
alxhub wants to merge 2 commits intoangular:mainfrom
Conversation
cb8f8e2 to
511babe
Compare
511babe to
b3f7cdd
Compare
Custom controls can be modeled using a set of host directives to alias and expose value and valueChange (or checked/checkedChange) bindings, as well as native attributes like disabled. This commit updates initializeCustomControlStatus to correctly identify host components using mapped inputs/outputs, even when those inputs are exposed via transitive host directives. It also updates customControlHasInput so that the custom control presence check correctly evaluates the exposed inputs across all applied host directives, caching the result to optimize performance on hot code paths.
…inputs Issue angular#65889 reported that FormUiControl does not support transformed inputs. This test asserts that FormValueControl components can legally use type-altering transforms for inputs like the disabled property. Closes angular#65889
b3f7cdd to
d10ce0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom controls can be modeled using a set of host directives to alias and expose value and valueChange (or checked/checkedChange) bindings, as well as native attributes like disabled.
This commit updates initializeCustomControlStatus to correctly identify host components using mapped inputs/outputs, even when those inputs are exposed via transitive host directives. It also updates customControlHasInput so that the custom control presence check correctly evaluates the exposed inputs across all applied host directives, caching the result to optimize performance on hot code paths.