Dedicated markdown-fence grammar support for angular-ts and angular-html#67357
Open
kbrilla wants to merge 3 commits intoangular:mainfrom
Open
Dedicated markdown-fence grammar support for angular-ts and angular-html#67357kbrilla wants to merge 3 commits intoangular:mainfrom
angular-ts and angular-html#67357kbrilla wants to merge 3 commits intoangular:mainfrom
Conversation
74da7a0 to
e20881d
Compare
JeanMeche
reviewed
Feb 27, 2026
vscode-ng-language-service/syntaxes/test/data/template-blocks.html.snap
Outdated
Show resolved
Hide resolved
b19a982 to
ce218eb
Compare
JeanMeche
reviewed
Mar 1, 2026
| cb: (error: any, exitCode?: number) => void, | ||
| ): Promise<void> { | ||
| const jasmine = new Jasmine({projectBaseDir: __dirname}); | ||
| (globalThis.jasmine as {DEFAULT_TIMEOUT_INTERVAL: number}).DEFAULT_TIMEOUT_INTERVAL = 60_000; |
Member
There was a problem hiding this comment.
Did you hit some some timouts on the tests ?
Contributor
Author
There was a problem hiding this comment.
Yes, but they were caused by macOS Keychain. Will remove that change here as it is mitigated.
kbrilla
commented
Mar 1, 2026
Comment on lines
+47
to
+48
| '--password-store=basic', | ||
| '--use-mock-keychain', |
Contributor
Author
There was a problem hiding this comment.
Added to stop timeouts caused by macOS keychain
d9f4d67 to
cd05b42
Compare
14 tasks
14 tasks
Stabilizes e2e activation/waits, runner launch args/timeouts, and test constants for markdown fixture targeting.
Adds angular-ts/angular-html markdown fence grammars and injection wiring for inline template/styles and host bindings in fenced contexts.
Include the fenced inline-template scope fix and checklist cleanup in the e2e coverage update so branch history stays at three commits.
caea029 to
7e27f89
Compare
JeanMeche
reviewed
Mar 3, 2026
| export const FOO_TEMPLATE_URI = pathToFileURL(FOO_TEMPLATE).href; | ||
| export const FOO_COMPONENT = join(PROJECT_PATH, 'app', 'foo.component.ts'); | ||
| export const FOO_COMPONENT_URI = pathToFileURL(FOO_COMPONENT).href; | ||
| export const MARKDOWN_FENCES = join(PROJECT_PATH, 'app', 'markdown-fences.md'); |
Member
There was a problem hiding this comment.
This file doesn't exist in this commit.
Contributor
Author
There was a problem hiding this comment.
It was part of the next commit. Moved this change to the test commit too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In markdown fenced Angular snippets (
angular-ts/angular-html), Angular template syntax is not consistently tokenized as Angular-aware scopes.This shows up as binding attributes/values and related expressions being treated like generic HTML attribute strings instead of Angular expression scopes.
Also, fixing this naively can cause a second issue: Angular binding highlighting bleeding outside fenced blocks into plain markdown HTML.
Fixes: #66641
What is the new behavior?
What is the behavior in this PR?
Does this PR introduce a breaking change?
Other information
mainand is scoped to VS Code extension grammar behavior for markdown-fenced Angular snippets.pnpm bazel test //vscode-ng-language-service/integration/e2e:test --test_output=errors --test_env=PATH=/opt/X11/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/homebrew/bin --nocache_test_results(pass)pnpm --dir vscode-ng-language-service run test(pass)angular-ts/angular-htmlblocks,tokenInfo.typechecks to reduce false positives.vscode-ng-language-service/syntaxes/test/databecause the risk addressed here is integration-level (fenced markdown + grammar injections + non-bleed boundaries), and this is covered by deterministic e2e assertions in this PR.