fix(docs-infra): reset webcontainer counter on OOM warning action#67364
Open
u-wlkjyy wants to merge 1 commit intoangular:mainfrom
Open
fix(docs-infra): reset webcontainer counter on OOM warning action#67364u-wlkjyy wants to merge 1 commit intoangular:mainfrom
u-wlkjyy wants to merge 1 commit intoangular:mainfrom
Conversation
Handle the stale webcontainer counter edge case when the browser crashes due to OOM and beforeunload is not fired. When users acknowledge the OOM warning, reset the counter and avoid repeated false-positive warnings.\n\nAdd unit tests covering counter reset behavior for OOM alerts and no-op behavior for mobile alerts.\n\nFixes angular#52647
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a browser tab crashes due to OOM, the
beforeunloadhandler may not fire. As a result, thenumberOfWebcontainerscounter can remain stale in local storage and repeatedly trigger the out-of-memory warning.Issue Number: #52647
What is the new behavior?
When the out-of-memory warning snackbar action (
I understand) is acknowledged, the webcontainer counter is reset to0.This also adds unit tests to verify:
Does this PR introduce a breaking change?
Other information
No docs-content changes are needed for this behavior fix.
Local checks run:
pnpm exec tslint -c tslint.json --project tsconfig-tslint.json adev/src/app/editor/alert-manager.service.ts adev/src/app/editor/alert-manager.service.spec.tsNote: full
pnpm test //adev:test --test_arg=--include=src/app/editor/alert-manager.service.spec.tscould not complete in this environment due disk-space limits during Bazel sandboxing.