Skip to content

refactor(platform-browser): remove Hammer integration#67496

Open
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:hammerjs
Open

refactor(platform-browser): remove Hammer integration#67496
JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche:hammerjs

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Mar 6, 2026

The integration was deprecated in v20 and will now be removed.

BREAKING CHANGE: Hammer.js integration has been removed. Use your own implementation.

@JeanMeche JeanMeche added the state: blocked on G3 cleanup This change requires a G3 cleanup label Mar 6, 2026
@JeanMeche JeanMeche added this to the v22 candidates milestone Mar 6, 2026
@ngbot ngbot bot removed this from the v22 candidates milestone Mar 6, 2026
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: core Issues related to the framework runtime labels Mar 6, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 6, 2026
@JeanMeche JeanMeche removed the state: blocked on G3 cleanup This change requires a G3 cleanup label Mar 9, 2026
@JeanMeche JeanMeche requested a review from thePunderWoman March 9, 2026 23:52
@JeanMeche JeanMeche marked this pull request as ready for review March 9, 2026 23:52
@pullapprove pullapprove bot requested a review from josephperrott March 9, 2026 23:52
thePunderWoman
thePunderWoman approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT-MC Hammer

@JeanMeche JeanMeche added the state: blocked on G3 cleanup This change requires a G3 cleanup label Mar 10, 2026
josephperrott
josephperrott approved these changes Mar 10, 2026
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pullapprove pullapprove bot requested review from atscott and kirjs March 10, 2026 18:41
@pullapprove pullapprove bot requested a review from crisbeto March 10, 2026 23:32
@pullapprove pullapprove bot requested review from atscott and kirjs March 10, 2026 23:32
@JeanMeche
refactor(platform-browser): remove Hammer integration
5a0a0aa 
The integration was deprecated in v20 and will now be removed.

BREAKING CHANGE: Hammer.js integration has been removed. Use your own implementation.
@JeanMeche JeanMeche removed request for atscott and kirjs March 12, 2026 17:34
@pullapprove pullapprove bot requested review from atscott and kirjs March 12, 2026 17:34
thePunderWoman
thePunderWoman approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're just waiting for the hammer to fall
https://tenor.com/view/freddie-mercury-queen-queen-band-hammer-hammer-to-fall-gif-24662747

reviewed-for: public-api

@JeanMeche JeanMeche added action: merge The PR is ready for merge by the caretaker and removed state: blocked on G3 cleanup This change requires a G3 cleanup labels Mar 12, 2026
@JeanMeche JeanMeche added target: major This PR is targeted for the next major release and removed action: merge The PR is ready for merge by the caretaker labels Mar 12, 2026
@JeanMeche JeanMeche removed request for atscott and kirjs March 12, 2026 18:03
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Mar 13, 2026
@ngbot
Copy link

ngbot bot commented Mar 13, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@kirjs kirjs kirjs approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@JeanMeche @thePunderWoman @kirjs @josephperrott