Skip to content

refactor(core): declare explicit reactive node prototypes types #67510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoostK wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −4
Open

refactor(core): declare explicit reactive node prototypes types #67510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/primitives/signals/src/computed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const ERRORED: any = /* @__PURE__ */ Symbol('ERRORED');

// Note: Using an IIFE here to ensure that the spread assignment is not considered
// a side-effect, ending up preserving `COMPUTED_NODE` and `REACTIVE_NODE`.
const COMPUTED_NODE = /* @__PURE__ */ (() => {
const COMPUTED_NODE: Omit<ComputedNode<unknown>, 'computation'> = /* @__PURE__ */ (() => {
return {
...REACTIVE_NODE,
value: UNSET,
Expand Down
5 changes: 4 additions & 1 deletion packages/core/primitives/signals/src/linked_signal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,10 @@ export function linkedSignalUpdateFn<S, D>(

// Note: Using an IIFE here to ensure that the spread assignment is not considered
// a side-effect, ending up preserving `LINKED_SIGNAL_NODE` and `REACTIVE_NODE`.
export const LINKED_SIGNAL_NODE: object = /* @__PURE__ */ (() => {
export const LINKED_SIGNAL_NODE: Omit<
LinkedSignalNode<unknown, unknown>,
'computation' | 'source' | 'sourceValue'
> = /* @__PURE__ */ (() => {
return {
...REACTIVE_NODE,
value: UNSET,
Expand Down
2 changes: 1 addition & 1 deletion packages/core/primitives/signals/src/watch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ const NOOP_CLEANUP_FN: WatchCleanupFn = () => {};

// Note: Using an IIFE here to ensure that the spread assignment is not considered
// a side-effect, ending up preserving `COMPUTED_NODE` and `REACTIVE_NODE`.
const WATCH_NODE: Partial<WatchNode> = /* @__PURE__ */ (() => {
const WATCH_NODE: Omit<WatchNode, 'fn' | 'schedule' | 'ref'> = /* @__PURE__ */ (() => {
return {
...REACTIVE_NODE,
consumerIsAlwaysLive: true,
Expand Down
5 changes: 4 additions & 1 deletion packages/core/src/render3/reactivity/after_render_effect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ export interface AfterRenderPhaseEffectNode extends SignalNode<unknown> {
phaseFn(previousValue?: unknown): unknown;
}

const AFTER_RENDER_PHASE_EFFECT_NODE = /* @__PURE__ */ (() => ({
const AFTER_RENDER_PHASE_EFFECT_NODE: Omit<
AfterRenderPhaseEffectNode,
'phase' | 'sequence' | 'userFn' | 'signal' | 'registerCleanupFn'
> = /* @__PURE__ */ (() => ({
...SIGNAL_NODE,
kind: 'afterRenderEffectPhase',
consumerIsAlwaysLive: true,
Expand Down