Skip to content

refactor(devtools): introduce prop-actions-menu#67645

Open
hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs:devtools/prop-actions-menu
Open

refactor(devtools): introduce prop-actions-menu#67645
hawkgs wants to merge 1 commit intoangular:mainfrom
hawkgs:devtools/prop-actions-menu

Conversation

@hawkgs
Copy link
Member

@hawkgs hawkgs commented Mar 12, 2026

Implement a context menu and add it to each property in the properties pane in order to optimize the available space by consolidating the action buttons of property items with multiple of them. Property items with a single action will retain their original behavior where the action button is directly available to click right after the displayed value.

Screenshot 2026-03-12 at 18 43 57 Screenshot 2026-03-12 at 18 44 05

@hawkgs hawkgs added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: devtools labels Mar 12, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 12, 2026
@pullapprove pullapprove bot requested a review from devversion March 12, 2026 16:52
@hawkgs hawkgs added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 12, 2026
@hawkgs hawkgs force-pushed the devtools/prop-actions-menu branch 2 times, most recently from c157bf5 to f29404d Compare March 13, 2026 13:11
Implement a context menu and add it to each property in the properties pane in order to optimize the available space by consolidating the action buttons of property items with multiple of them. Property items with a single action will retain their original behavior where the action button is directly available to click right after the displayed value.
@hawkgs hawkgs force-pushed the devtools/prop-actions-menu branch from f29404d to 04c7533 Compare March 13, 2026 13:25
@hawkgs hawkgs added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 13, 2026
@hawkgs hawkgs removed the request for review from devversion March 13, 2026 14:29
@pullapprove pullapprove bot requested a review from devversion March 13, 2026 14:29
Comment on lines +73 to +76
// Note(hawkgs): Test temporary disabled because
// it causes frequent flakes.
//
// it('should return root element', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fix is introduced in #67682.

Will keep the comments until one of these is merged to avoid CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: devtools target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant