docs: add doc to focusBoundControl feature#67667
docs: add doc to focusBoundControl feature#67667rblmdst wants to merge 2 commits intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
577edbf to
20f3aeb
Compare
| @Component({/* ... */}) | ||
| export class PasswordInput implements FormValueControl<string> { | ||
| readonly value = model<string>(''); | ||
| readonly passwordCtrl = viewChild.required<ElementRef>('passwordCtrl'); |
There was a problem hiding this comment.
You can specify the type in the generic ElementRef so we avoid having to do the casting later.
| readonly passwordCtrl = viewChild.required<ElementRef>('passwordCtrl'); | |
| readonly passwordCtrl = viewChild.required<ElementRef<HTMLInputElement>>('passwordCtrl'); |
|
|
||
| ### Preventing scroll | ||
|
|
||
| If the target control is outside the viewport and you want to focus it without triggering a scroll, pass `{ preventScroll: true }`: |
There was a problem hiding this comment.
We could add a link in preventScroll or in focus to clarify what preventScroll does. Normally we reference MDN for this
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus#preventscroll
|
The topic covered seem to be a bit small the justify a dedicated guide. Also currently this file is orphan, it's isn't referenced in |
…isting field state doc
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information