docs(adev): reset webcontainer counter after OOM warning dismissal#67676
Open
tianxingleo wants to merge 2 commits intoangular:mainfrom
Open
docs(adev): reset webcontainer counter after OOM warning dismissal#67676tianxingleo wants to merge 2 commits intoangular:mainfrom
tianxingleo wants to merge 2 commits intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
josephperrott
requested changes
Mar 16, 2026
Member
josephperrott
left a comment
There was a problem hiding this comment.
Can you please collapse the two commits into one.
We do not need a separate test scoped commit for creating the test, we can include the test in the fix commit.
| } | ||
|
|
||
| private resetInstancesCounter(): void { | ||
| this.localStorage?.setItem(WEBCONTAINERS_COUNTER_KEY, '0'); |
Member
There was a problem hiding this comment.
Resetting the counters should reset to 1 since the currently running instance is active.
Suggested change
| this.localStorage?.setItem(WEBCONTAINERS_COUNTER_KEY, '0'); | |
| this.localStorage?.setItem(WEBCONTAINERS_COUNTER_KEY, '1'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #52647 in the docs embedded editor.
When Safari reloads a tab after OOM,
beforeunloadmay not fire, sonumberOfWebcontainerscan stay stale in localStorage. That can cause the OOM warning to appear even when the user has fewer than the recommended number of tabs open.This change resets the webcontainer instances counter when the user dismisses the OOM warning (
I understand).Changes
AlertManagernumberOfWebcontainersto0on dismissalAlertManagerunit tests for increment/decrement/reset behaviorTesting
alert-manager.service.spec.tscoverage for:beforeunload