Skip to content

Rules angular update [patch]#67677

Merged
mattrbeck merged 2 commits intoangular:21.2.xfrom
alan-agius4:rollup-adev
Mar 13, 2026
Merged

Rules angular update [patch]#67677
mattrbeck merged 2 commits intoangular:21.2.xfrom
alan-agius4:rollup-adev

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Mar 13, 2026

Explicitly adding an export {} to modules containing declare global fixes an issue where Rollup would incorrectly claim that the global variable is not defined in the emitted .d.ts files.

Needed to land the latest rules_angular.

@alan-agius4 alan-agius4 requested a review from JeanMeche March 13, 2026 07:21
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 13, 2026
…by Rollup

Explicitly adding an `export {}` to modules containing declare global fixes an issue where Rollup would incorrectly claim that the global variable is not defined in the emitted .d.ts files.

Needed to land the latest rules_angular.
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project area: performance Issues related to performance labels Mar 13, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 13, 2026
@angular-robot angular-robot bot added area: common/http Issues related to HTTP and HTTP Client area: compiler Issues related to `ngc`, Angular's template compiler area: core Issues related to the framework runtime area: docs-infra Angular.dev application and infrastructure area: language-service Issues related to Angular's VS Code language service area: common Issues related to APIs in the @angular/common package area: forms labels Mar 13, 2026
Update rules_angular to latest sha
@angular-robot angular-robot bot added area: vscode-extension Issues related to the Angular Language Service VsCode extension area: router area: devtools requires: TGP This PR requires a passing TGP before merging is allowed labels Mar 13, 2026
@alan-agius4 alan-agius4 changed the base branch from main to 21.2.x March 13, 2026 13:55
@alan-agius4 alan-agius4 removed area: build & ci Related the build and CI infrastructure of the project area: common Issues related to APIs in the @angular/common package labels Mar 13, 2026
@alan-agius4 alan-agius4 removed detected: breaking change PR contains a commit with a breaking change area: docs-infra Angular.dev application and infrastructure area: vscode-extension Issues related to the Angular Language Service VsCode extension labels Mar 13, 2026
@ngbot ngbot bot modified the milestone: Backlog Mar 13, 2026
@alan-agius4 alan-agius4 removed detected: feature PR contains a feature commit requires: TGP This PR requires a passing TGP before merging is allowed labels Mar 13, 2026
@alan-agius4 alan-agius4 reopened this Mar 13, 2026
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 13, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 13, 2026
@alan-agius4 alan-agius4 changed the title refactor: ensure modules with 'declare global' are correctly handled by Rollup Rules angular update [patch] Mar 13, 2026
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 13, 2026
@mattrbeck mattrbeck merged commit 5b46a63 into angular:21.2.x Mar 13, 2026
21 checks passed
@mattrbeck
Copy link
Member

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the rollup-adev branch March 13, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants