fix(compiler-cli): escape template literal in TCB#67678
Open
crisbeto wants to merge 1 commit intoangular:mainfrom
Open
fix(compiler-cli): escape template literal in TCB#67678crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
JoostK
reviewed
Mar 15, 2026
Member
JoostK
left a comment
There was a problem hiding this comment.
A test in https://github.com/angular/angular/blob/main/packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts would be meaningful to verify the template is checked as expected;
@Component({
template: `
@let var = `Version: \`${check(version)}\``;
`
})
export class Cmp {
version = 'test'
check(input: number): string {
return String(input);
}
}Should report a type assignability error from string to number. That shows that the template's substitutions are type-checked as expected.
Fixes a regression introduced by angular#67381 where we weren't escaping backticks in template literals. Fixes angular#67675.
a5b4ef7 to
1729e55
Compare
Member
Author
|
Added the extra test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #67381 where we weren't escaping backticks in template literals.
Fixes #67675.