Merged
Conversation
…by Rollup
Explicitly adding an `export {}` to modules containing declare global fixes an issue where Rollup would incorrectly claim that the global variable is not defined in the emitted .d.ts files.
Needed to land the latest rules_angular.
Update rules_angular to latest sha
1692e56 to
468a4b3
Compare
alan-agius4
commented
Mar 13, 2026
| } | ||
|
|
||
| private onMessageError(event: ExtendableMessageEvent): void { | ||
| private onMessageError(event: MessageEvent<unknown>): void { |
Contributor
Author
There was a problem hiding this comment.
The type here was incorrect for TS 6.0 the error is also shown in the IDE but was not surfaced before due to an issue with rules_angular workers which didn't use the workspace TS version.
FYI: @josephperrott
crisbeto
approved these changes
Mar 13, 2026
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.