Skip to content

test(devtools): fix and update flaky component-tree tests #67682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hawkgs wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

test(devtools): fix and update flaky component-tree tests #67682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion devtools/projects/ng-devtools-backend/src/lib/component-tree/component-tree.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,13 @@ describe('component-tree', () => {
describe('getRootElements', () => {
beforeEach(() => {
const ng: Partial<Ng> = {
getComponent: jasmine.createSpy('getComponent').and.returnValue({}),
getComponent: jasmine.createSpy('getComponent').and.callFake((element: HTMLElement) => {
// Will treat only `ng-*` elements as Angular components.
if (element.tagName.toLowerCase().startsWith('ng-')) {
return element;
}
return null;
}),
};
(window as any).ng = ng;
});
Expand Down Expand Up @@ -105,6 +111,21 @@ describe('component-tree', () => {
expect(roots.length).toEqual(1);
expect(roots).toContain(document.body);
});

it('should return all root elements with all non-application root components', () => {
const rootElement = createRoot();
const childElement = createRoot();
const nonAppRootCmp = document.createElement('ng-cmp');

rootElement.appendChild(childElement);
document.body.appendChild(rootElement);
document.body.appendChild(nonAppRootCmp);

const roots = getRootElements();

expect(roots.length).toEqual(2);
expect(roots).toEqual([rootElement, nonAppRootCmp]);
});
});

describe('serializeProviderRecord', () => {
Expand Down
Loading