Skip to content

fix(compiler-cli): generic types not filled out correctly in type check block#67707

Open
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:67704/generic-emit
Open

fix(compiler-cli): generic types not filled out correctly in type check block#67707
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:67704/generic-emit

Conversation

@crisbeto
Copy link
Member

Fixes a regression caused by the recent TCB changes where we moved the type parameter processing earlier in the pipeline and stopped properly accounting for the TcbGenericContextBehavior.

Fixes #67704.

@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 16, 2026
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Mar 16, 2026
@ngbot ngbot bot added this to the Backlog milestone Mar 16, 2026
@crisbeto crisbeto requested review from atscott and mattrbeck March 16, 2026 17:14
@crisbeto crisbeto marked this pull request as ready for review March 16, 2026 17:14
…ck block

Fixes a regression caused by the recent TCB changes where we moved the type parameter processing earlier in the pipeline and stopped properly accounting for the `TcbGenericContextBehavior`.

Fixes angular#67704.
@crisbeto crisbeto force-pushed the 67704/generic-emit branch from 869d14b to 58cc4a6 Compare March 16, 2026 19:52
@crisbeto crisbeto added action: global presubmit The PR is in need of a google3 global presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 16, 2026
@crisbeto
Copy link
Member Author

Passing TGP

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: global presubmit The PR is in need of a google3 global presubmit labels Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project no longer compiles after upgrading from 21.2.2 to 21.2.3

4 participants