fix(compiler): allow digits in named character reference entity names#67716
Closed
mango766 wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): allow digits in named character reference entity names#67716mango766 wants to merge 1 commit intoangular:mainfrom
mango766 wants to merge 1 commit intoangular:mainfrom
Conversation
The `isNamedEntityEnd` function in the HTML lexer only recognized ASCII letters as valid characters within named entity names. This caused all 24 HTML named character references that contain digits (e.g. `¹`, `½`, `░`, `∴`, ` `) to be incorrectly parsed. The lexer would stop reading at the first digit, fail to find the terminating semicolon, and fall back to emitting `&` as literal text — effectively breaking these entities. The fix adds `chars.isDigit(code)` to the `isNamedEntityEnd` predicate so that digits are treated as valid continuation characters in named entity names, matching the HTML spec. Fixes angular#51323
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
This a duplicated of #67229 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Named HTML character references containing digits (e.g.
¹,½,░,∴, ) are not processed correctly in Angular templates. There are 24 such entities defined in the HTML spec, and none of them render properly.Root cause
The
isNamedEntityEndfunction inpackages/compiler/src/ml_parser/lexer.tsuses!chars.isAsciiLetter(code)to determine when the entity name ends. Since digits are not ASCII letters, the lexer stops reading the entity name prematurely when it encounters a digit character.For example, when parsing
¹:s,u,p(all ASCII letters ✓)1—isAsciiLetter('1')isfalse, so it stopssupinstead ofsup11, not;, so the entity parse fails&as literal textFix
Added
!chars.isDigit(code)to theisNamedEntityEndpredicate so that digits are treated as valid continuation characters in named entity names. This matches the HTML spec, which allows alphanumeric characters in named character references.Test plan
'should parse named entities containing digits'covering 6 different entities:¹,½,¾,░,∴, there4caseNAMED_ENTITIEStable inentities.tsFixes #51323