docs(router): clarify router.navigate() behavior with relativeTo and commands array#67723
docs(router): clarify router.navigate() behavior with relativeTo and commands array#67723anushkasingh-commits wants to merge 4 commits intoangular:mainfrom
Conversation
|
Thanks for the clarification! I've updated the wording to focus specifically on parent route navigation. |
…elativeTo Clarified usage of 'relativeTo' option for parent routes.
|
|
||
| You can also build dynamic navigation paths relative to your component’s location in the routing tree using the `relativeTo` option. | ||
|
|
||
| When navigating to parent routes using `relativeTo`, parent segments should be provided as a single command (for example `'../../path'`). Splitting them into multiple entries (e.g. `'..', '..', 'path'`) may not produce the expected navigation result. |
There was a problem hiding this comment.
What do you mean by “may not” and what are “expected results? Documentation should focus on what the behavior does not what it does not do
|
Thanks for the clarification! I've updated the wording to clearly describe the actual behavior instead of using ambiguous phrasing. |
|
Thanks for the review! I understand the feedback regarding focusing on actual behavior. I’ll refine this approach in future contributions. |
|
Sorry but this isn't working for us. Reviewing your contributions is more work that doing it ourselves. We understand that LLMs may appear to help for contributions but they often don't provide good enough results to pass the threshold of expectations. |
|
Thanks for the feedback. I understand, and I appreciate you taking the time to review this. I’ll improve my approach in future contributions. |
Summary
Adds a small clarification to the
router.navigate()documentation to address confusion when using the commands array withrelativeTo.Changes
/withrelativeToNotes
Fixes #65657