fix(forms): allow FormRoot to be used without submission options#67727
Open
leonsenft wants to merge 2 commits intoangular:mainfrom
Open
fix(forms): allow FormRoot to be used without submission options#67727leonsenft wants to merge 2 commits intoangular:mainfrom
leonsenft wants to merge 2 commits intoangular:mainfrom
Conversation
- **FormField**: `form_field_directive.ts` -> `form_field.ts` - **FormRoot**: `ng_signal_form.ts` -> `form_root.ts`
The `[formRoot]` directive will no longer call `submit()` if the bound form doesn't define its own submission options. This allows the directive to be used solely for the default behavior it provides: setting `novalidate` on the `<form>` and calling `preventDefault()` on the `submit` event. Fix angular#67367
e4ff0e2 to
bff5cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
[formRoot]directive will no longer callsubmit()if the bound form doesn't define its own submission options. This allows the directive to be used solely for the default behavior it provides: settingnovalidateon the<form>and callingpreventDefault()on thesubmitevent.Fix #67367