Closed
Conversation
pkozlowski-opensource
added a commit
to pkozlowski-opensource/angular-app
that referenced
this pull request
Aug 6, 2014
Member
|
@buberdds I'm so sorry that it took us so much time to get back to you, we should be better at managing PRs :-/ So, the breaking news is that we are starting work on the second edition of the book and as part of this effort going to update this sample app. For the update we've decided to go with gulp and so our build won't look the same. Both Peter and I really appreciate your work but just don't want to merge this PR now in order to avoid merge conflicts in the future. FYI, here is how the new build with minifcation is going to look like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I'm trying to resolve issue #95 and I need your feedback. Is this sollution ok, or you expect something else?
Run minify process only while in a release task maybe?