Return reject promise in securityInterceptor#258
Closed
ravishivt wants to merge 1 commit intoangular-app:second_editionfrom
Closed
Return reject promise in securityInterceptor#258ravishivt wants to merge 1 commit intoangular-app:second_editionfrom
ravishivt wants to merge 1 commit intoangular-app:second_editionfrom
Conversation
As per angular/angular.js#2609, $http calls always processed their success callback because the interceptor stripped out the reject promise.
Closed
Contributor
|
Great. Thanks |
petebacondarwin
pushed a commit
that referenced
this pull request
Aug 27, 2014
As per angular/angular.js#2609, $http requests always execute their success handler if the interceptor doesn't return a rejection. Closes #258
Contributor
|
Fixed up the unit test and landed in second_edition branch. Thanks |
petebacondarwin
pushed a commit
that referenced
this pull request
Sep 1, 2014
As per angular/angular.js#2609, $http requests always execute their success handler if the interceptor doesn't return a rejection. Closes #258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per angular/angular.js#2609, $http calls
always processed their success callback because the interceptor
stripped out the reject promise.