-
Notifications
You must be signed in to change notification settings - Fork 221
fix: keep minSize, even when size is undefined #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any ETA on when this will be pushed? |
|
Any updates? |
|
Hi @Gwe-n, recently @beeman handed over the maintenance to myself and @SanderElias. Could you provide me a update on this PR and resolve the conflicts? After this we will review your PR. |
|
Hi @Jefiozie I have resolved the conflicts in question. I must admit that this subject is now far from my mind 😅 Don't hesitate to close this PR if the patch doesn't fix the issue |
Jefiozie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
|
@SanderElias could you also do a review |
|
@all-contributors please add @Gwe-n for code.
|
|
I've put up a pull request to add @Gwe-n! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
Fix #255