Skip to content

Conversation

@Gwe-n
Copy link
Contributor

@Gwe-n Gwe-n commented Aug 27, 2020

Fix #255

@beeman beeman changed the base branch from master to main November 22, 2020 03:29
@DerekJDev
Copy link

Any ETA on when this will be pushed?

@gtteamamxx
Copy link

Any updates?
@beeman

@Jefiozie
Copy link
Member

Hi @Gwe-n, recently @beeman handed over the maintenance to myself and @SanderElias.

Could you provide me a update on this PR and resolve the conflicts? After this we will review your PR.

@Jefiozie Jefiozie added the waiting-for-reply Waiting for reply or confirmation of user creating the issue. label Jan 22, 2024
@Gwe-n
Copy link
Contributor Author

Gwe-n commented Jan 22, 2024

Hi @Jefiozie I have resolved the conflicts in question. I must admit that this subject is now far from my mind 😅 Don't hesitate to close this PR if the patch doesn't fix the issue

@Jefiozie Jefiozie removed the waiting-for-reply Waiting for reply or confirmation of user creating the issue. label Jan 22, 2024
@Jefiozie Jefiozie changed the title Fix: Keep minSize, even when size is undefined fix: keep minSize, even when size is undefined Jan 24, 2024
Copy link
Member

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Jefiozie
Copy link
Member

@SanderElias could you also do a review

@SanderElias SanderElias merged commit bc139ee into angular-split:main Jan 25, 2024
@Jefiozie
Copy link
Member

@all-contributors please add @Gwe-n for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Contributor

@Jefiozie

I've put up a pull request to add @Gwe-n! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@Gwe-n Gwe-n deleted the fix-min-size branch January 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minSize doesn't work

5 participants