fix: fire dragStart event only when a cursor is moved (#283) #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@nomeaning777 this looks awesome, great job! I'm going to give it a quick local run this weekend to make sure I fully understand the changes, and it will be deployed with v5! 🎉 |
Member
|
@all-contributors please add @nomeaning777 for code.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, angular-split doesn't always fire dragEnd event after dragStart instead it fires gutterClick / gutterDblClick when the cursor/touch position is not moved.
In this PR, dragStart is delayed until initial cursor/touch position move to avoid such inconsistency.
fixes #283