fix: correctly type the size property #289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a1a65f to
f3f84c7
Compare
lf-novelt
reviewed
Mar 1, 2021
| y: number | ||
| } | ||
|
|
||
| export type IAreaSize = number | '*' |
Contributor
There was a problem hiding this comment.
weird to prefix a type (not an interface) with the capital I prefix that means Interface :P
Collaborator
Author
There was a problem hiding this comment.
Good point @lf-novelt - I'm not a fan of the I for interfaces either, it's more a matter of keeping consistency.
Contributor
|
Thanks for the PR. |
|
Has this been merged yet? Still having the issue; using the $any('*') workaround for now |
Collaborator
Author
Sorry, little time for maintenance currently. I will see if I can cut a release and include this change. |
|
Can you merge this modification? |
|
Is there a plan to release this PR? |
Collaborator
|
@beeman The PR seems good... Any reason to wait with it? |
|
For the people who are waiting this PR. This PR is still waiting for some reasons. For example: <as-split
[direction]="'horizontal'"
[unit]="'pixel'"
>
<as-split-area
[size]="280"
[maxSize]="280">
A
</as-split-area>
<as-split-area
[size]="$any('*')">
B
</as-split-area>
</as-split> |
marksvc
added a commit
to sillsdev/web-xforge
that referenced
this pull request
Aug 29, 2023
In situations where we hide the text, intending just for the audio
player to be used, the patch makes the text+audio area have a maximum
size of the height needed by the audio player (109 px), to just show
the audio player. The audio area can still be made smaller to move it
up out of the way.
In the case where we do not hide the text, and whether or not there is
audio, still we show the question area as a smaller area near the
bottom of the screen, with the Scripture text area using most of the
available space. Though I made the question area slightly bigger than
it was before so the "Add answer" button has a greater chance of being
fully visible (170 px).
Using `$any('*')` workaround until this PR is merged:
angular-split/angular-split#289
After that, just `'*'` can be used.
marksvc
added a commit
to sillsdev/web-xforge
that referenced
this pull request
Aug 30, 2023
In situations where we hide the text, intending just for the audio
player to be used, the patch makes the text+audio area have a maximum
size of the height needed by the audio player (109 px), to just show
the audio player. The audio area can still be made smaller to move it
up out of the way.
In the case where we do not hide the text, and whether or not there is
audio, still we show the question area as a smaller area near the
bottom of the screen, with the Scripture text area using most of the
available space. Though I made the question area slightly bigger than
it was before so the "Add answer" button has a greater chance of being
fully visible (170 px).
Using `$any('*')` workaround until this PR is merged:
angular-split/angular-split#289
After that, just `'*'` can be used.
marksvc
added a commit
to sillsdev/web-xforge
that referenced
this pull request
Aug 31, 2023
In situations where we hide the text, intending just for the audio
player to be used, the patch makes the text+audio area have a maximum
size of the height needed by the audio player (109 px), to just show
the audio player. The audio area can still be made smaller to move it
up out of the way.
In the case where we do not hide the text, and whether or not there is
audio, still we show the question area as a smaller area near the
bottom of the screen, with the Scripture text area using most of the
available space. Though I made the question area slightly bigger than
it was before so the "Add answer" button has a greater chance of being
fully visible (170 px).
Using `$any('*')` workaround until this PR is merged:
angular-split/angular-split#289
After that, just `'*'` can be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #220