Skip to content

Conversation

@Jefiozie
Copy link
Member

@Jefiozie Jefiozie commented Jan 23, 2024

In this Pull Request (PR), we are excited to introduce several enhancements to our Continuous Integration (CI) process. Below is an overview of the newly added functionalities:

Compliance: This action aids in handling incoming PRs that may require adjustments beyond just code.

Note: The Compliance check is currently failing due to permission issues. This will be resolved once the changes are merged.

Contributions: Utilizing the @all-contributors add bot, this feature automatically posts acknowledgments in the most recent issues and PRs for each contributor's efforts.

Build: This action builds both the application and the library.

Lint: This step lints the application and library, ensuring code quality and consistency.

Test: We've implemented an end-to-end (e2e) testing process.

Dependency Review: This function scans dependencies to identify and report on vulnerable packages.

License: Scheduled to run annually (or manually), this action updates the License file with the current year.

Release-Please: This automates the release process based on specific types of git commits, such as fixes or new features.

Additionally, we have integrated commitlint to validate the commits made on the clients, enhancing the overall quality and consistency of our commit history.

this will close: #375 and #376

@Jefiozie
Copy link
Member Author

Lint will also fail as the PR #382 is not yet merged

@Jefiozie Jefiozie changed the title feat: introduce complaince check for PR feat: improve CI workflows Jan 23, 2024
Copy link
Contributor

@SanderElias SanderElias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
1 nit tho, I think we should move all CI?Cd to node 20 now

@Jefiozie
Copy link
Member Author

Looks good to me 1 nit tho, I think we should move all CI?Cd to node 20 now

Should we also build, lint test etc on the main branch?

@Jefiozie Jefiozie changed the title feat: improve CI workflows feat: improve CI workflow Jan 24, 2024
@Jefiozie
Copy link
Member Author

Looks good to me 1 nit tho, I think we should move all CI?Cd to node 20 now

@SanderElias I've changed it to node 20.x

@Jefiozie Jefiozie requested a review from SanderElias January 24, 2024 06:41
@SanderElias
Copy link
Contributor

Can this be merged now?

@Jefiozie
Copy link
Member Author

@SanderElias when all actions are green, except complaince, Yes!

@SanderElias SanderElias merged commit 4d0608d into angular-split:main Jan 24, 2024
@Jefiozie
Copy link
Member Author

@all-contributors please add @SanderElias for maintenance.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Contributor

@Jefiozie

I've put up a pull request to add @SanderElias! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimizing CI Pipeline: Comprehensive Build, Lint, Test, and Automated Release Workflow

2 participants