-
Notifications
You must be signed in to change notification settings - Fork 221
feat: improve CI workflow #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f330db to
8904051
Compare
|
Lint will also fail as the PR #382 is not yet merged |
SanderElias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
1 nit tho, I think we should move all CI?Cd to node 20 now
Should we also build, lint test etc on the main branch? |
…ll automatic make a contribution branch
72c2f72 to
2e781a0
Compare
@SanderElias I've changed it to node 20.x |
|
Can this be merged now? |
|
@SanderElias when all actions are green, except complaince, Yes! |
|
@all-contributors please add @SanderElias for maintenance.
|
|
I've put up a pull request to add @SanderElias! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
In this Pull Request (PR), we are excited to introduce several enhancements to our Continuous Integration (CI) process. Below is an overview of the newly added functionalities:
Compliance: This action aids in handling incoming PRs that may require adjustments beyond just code.
Contributions: Utilizing the @all-contributors add bot, this feature automatically posts acknowledgments in the most recent issues and PRs for each contributor's efforts.
Build: This action builds both the application and the library.
Lint: This step lints the application and library, ensuring code quality and consistency.
Test: We've implemented an end-to-end (e2e) testing process.
Dependency Review: This function scans dependencies to identify and report on vulnerable packages.
License: Scheduled to run annually (or manually), this action updates the License file with the current year.
Release-Please: This automates the release process based on specific types of git commits, such as fixes or new features.
Additionally, we have integrated commitlint to validate the commits made on the clients, enhancing the overall quality and consistency of our commit history.
this will close: #375 and #376