Skip to content

test: fixed package-lock #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jefiozie merged 1 commit into from
May 2, 2024
Merged

test: fixed package-lock #436

Jefiozie merged 1 commit into from
May 2, 2024

Conversation

@SanderElias
Copy link
Contributor

@SanderElias SanderElias commented Apr 30, 2024 •
edited
Loading

related to issue #435

This package-lock should work on windows. Awaiting result form that.

@SanderElias
Copy link
Contributor Author

SanderElias commented Apr 30, 2024

@Harpush @Jefiozie Can you test if npm install works for this branch?

@Harpush
Copy link
Collaborator

Harpush commented Apr 30, 2024

@SanderElias After nuking node_modules and trying a clean npm install - seems to work!

@SanderElias SanderElias marked this pull request as ready for review May 1, 2024 04:18
@SanderElias SanderElias requested review from Harpush and Jefiozie May 1, 2024 04:18
Jefiozie
Jefiozie approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jefiozie Jefiozie merged commit 8fc540e into main May 2, 2024
@Jefiozie Jefiozie deleted the test_angulapr_eslint branch May 2, 2024 07:33
@Jefiozie
Copy link
Member

Jefiozie commented Feb 2, 2025

@all-contributors please add @SanderElias for test.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Feb 2, 2025
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Feb 2, 2025

@Jefiozie

I've put up a pull request to add @SanderElias! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jefiozie Jefiozie Jefiozie approved these changes

@Harpush Harpush Awaiting requested review from Harpush

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SanderElias @Harpush @Jefiozie