Open
Conversation
alamb
reviewed
Sep 8, 2025
Contributor
alamb
left a comment
There was a problem hiding this comment.
Thanks @jecsand838 -- any chance we can reduce the size of this PR?
Contributor
There was a problem hiding this comment.
notice this file is 3.1KB -- and given this repo is widely used I wonder if there is any way to reduce the size of the example file?
Contributor
Author
There was a problem hiding this comment.
100% I'll check into it this week. Just getting caught up with these arrow-test PRs.
Contributor
There was a problem hiding this comment.
sorry for the delayed reviews
Contributor
Author
There was a problem hiding this comment.
sorry for the delayed reviews
@alamb It's all good. You're literally everywhere, I totally get it. In fact thank you for getting to them at the pace you are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
skippable_types.avrofile which will be used to testarrow-avroagain files with zero byte records..Here's the python script used to generate the new Avro file: https://gist.github.com/jecsand838/82d9874a5f9be8a636dcd49ad9b8e237
Part of apache/arrow-rs#4886