Skip to content

Support Linstor Primary Storage for NAS BnR#12796

Open
abh1sar wants to merge 1 commit intoapache:4.22from
shapeblue:linstor-nas
Open

Support Linstor Primary Storage for NAS BnR#12796
abh1sar wants to merge 1 commit intoapache:4.22from
shapeblue:linstor-nas

Conversation

@abh1sar
Copy link
Contributor

@abh1sar abh1sar commented Mar 12, 2026

Description

This PR fixes #12218

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  1. Backup from Linstor Primary Storage to NAS NFS backup repository
  2. Restore from Backup to Linstor Primary Storage
  3. Create new Instance from Backup to Linstor Primary Storage
  4. Restore Backup to NFS Primary Storage
  5. Create new Instance from Backup to NFS Primary Storage

Validated Data after Restore.

How did you try to break this feature and the system with this change?

@abh1sar abh1sar requested a review from sureshanaparti March 12, 2026 06:33
@codecov
Copy link

codecov bot commented Mar 12, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.70%. Comparing base (5caf6cd) to head (e339137).
⚠️ Report is 19 commits behind head on 4.22.

❗ There is a different number of reports uploaded between BASE (5caf6cd) and HEAD (e339137). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5caf6cd) HEAD (e339137)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.22   #12796       +/-   ##
=============================================
- Coverage     17.60%    3.70%   -13.91%     
=============================================
  Files          5917      448     -5469     
  Lines        531394    38019   -493375     
  Branches      64970     7035    -57935     
=============================================
- Hits          93575     1409    -92166     
+ Misses       427269    36423   -390846     
+ Partials      10550      187    -10363
Flag Coverage Δ
uitests 3.70% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti
sureshanaparti reviewed Mar 12, 2026
View reviewed changes
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java
volumePathPrefix = storagePool.getPath();
volumePathPrefix = storagePool.getPath() + "/";
} else if (Storage.StoragePoolType.Linstor.equals(storagePool.getPoolType())) {
volumePathPrefix = "/dev/drbd/by-res/cs-";
Copy link
Contributor

@sureshanaparti sureshanaparti Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can keep this path in LinstorUtil, and use it here

Copy link
Contributor Author

@abh1sar abh1sar Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't access LinstorUtil from here.

@sureshanaparti sureshanaparti linked an issue Mar 12, 2026 that may be closed by this pull request
Create Instance from Backup Failed #12218
Open
@sureshanaparti sureshanaparti requested a review from rp- March 12, 2026 07:40
@sureshanaparti sureshanaparti added this to the 4.22.1 milestone Mar 12, 2026
@sureshanaparti
Copy link
Contributor

sureshanaparti commented Mar 12, 2026

Hi @rp- Can you perform some tests with this PR changes and confirm?

abh1sar
abh1sar commented Mar 13, 2026
View reviewed changes
.../main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreBackupCommandWrapper.java
if (Storage.StoragePoolType.Linstor.equals(volumePool.getPoolType())) {
storagePoolMgr.connectPhysicalDisk(volumePool.getPoolType(), volumePool.getUuid(), volumeUuid, null);
} else {
disk = volumeStoragePool.getPhysicalDisk(getVolumeUuidFromPath(volumePath, volumePool));
Copy link
Contributor Author

@abh1sar abh1sar Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti can you please review from RBD's regression perspective?

volumeStoragePool.getPhysicalDisk takes UUID as an argument. previously it was passing path

Copy link
Contributor

@sureshanaparti sureshanaparti Mar 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abh1sar usually, better to lookup by volume path, not the uuid. I checked in my earlier testing, the uuid and path are the same for volumes on ceph, we've to check after migrate volume, any other operation which can changes the path and not uuid. to avoid any issue, can you check for StoragePoolType.RBD and get disk by volume path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sureshanaparti sureshanaparti sureshanaparti left review comments

@rp- rp- Awaiting requested review from rp-

Assignees

No one assigned

Labels

component:backup component:kvm status:needs-testing

Projects

Apache CloudStack 4.22.1
Status: In Progress

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

Create Instance from Backup Failed

2 participants

@abh1sar @sureshanaparti