Load arch data for backup from template during create instance from backup#12801
Load arch data for backup from template during create instance from backup#12801sudo87 wants to merge 3 commits intoapache:4.22from
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes UI behavior when creating an instance from a backup in multi-arch zones by carrying over the source template’s architecture so template/ISO listings can be filtered consistently.
Changes:
- Fetch template architecture during “Create VM from Backup” initialization and pass it via
dataPreFill. - Initialize/adjust selected architecture in the deployment wizard based on prefilled template arch and selected template arch.
- Remove the zone-selection-time forced architecture reset to avoid overriding the backup/template architecture.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui/src/views/storage/CreateVMFromBackup.vue | Adds template-arch lookup and passes it to the deploy wizard via dataPreFill. |
| ui/src/components/view/DeployVMFromBackup.vue | Uses prefilled template architecture to set selectedArchitecture, updates it on template selection, and changes zone-selection behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| @@ -2344,9 +2346,6 @@ export default { | |||
| this.clusterId = null | |||
| this.zone = _.find(this.options.zones, (option) => option.id === value) | |||
| this.isZoneSelectedMultiArch = this.zone.ismultiarch | |||
There was a problem hiding this comment.
Removing the multi-arch defaulting in onSelectZoneId can leave selectedArchitecture as null for the ISO flow (dataPreFill.isIso === true), because created() only initializes selectedArchitecture in the template tab. fetchIsos() will still add args.architecture = this.selectedArchitecture whenever isZoneSelectedMultiArch is true, so multi-arch zones may end up calling listIsos with an empty/null architecture filter and return no results. Fix by ensuring selectedArchitecture is initialized (e.g. to architectureTypes.opts[0].id) when entering a multi-arch zone if it’s currently unset, or by only sending the architecture param when it has a value.
| this.isZoneSelectedMultiArch = this.zone.ismultiarch | |
| this.isZoneSelectedMultiArch = this.zone.ismultiarch | |
| if (this.isZoneSelectedMultiArch && | |
| !this.selectedArchitecture && | |
| this.architectureTypes && | |
| Array.isArray(this.architectureTypes.opts) && | |
| this.architectureTypes.opts.length > 0) { | |
| this.selectedArchitecture = this.architectureTypes.opts[0].id | |
| } |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12801 +/- ##
============================================
- Coverage 17.61% 17.61% -0.01%
+ Complexity 15664 15662 -2
============================================
Files 5917 5917
Lines 531402 531395 -7
Branches 64971 64972 +1
============================================
- Hits 93596 93588 -8
+ Misses 427252 427251 -1
- Partials 10554 10556 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@sudo87 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Description
This PR fixes issue #12444
Arch info is fetched from the template and is used to fetch the relevant templates.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Screen.Recording.2026-03-12.at.11.08.11.PM.mov
How Has This Been Tested?
How did you try to break this feature and the system with this change?