pre-commit trailing whitespace auto clean up#12841
Open
jbampton wants to merge 1 commit intoapache:mainfrom
Open
pre-commit trailing whitespace auto clean up#12841jbampton wants to merge 1 commit intoapache:mainfrom
jbampton wants to merge 1 commit intoapache:mainfrom
Conversation
Now targetting more files and file types Also minor change to the markdown lint hook since we only have ".md" files
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12841 +/- ##
=========================================
Coverage 18.02% 18.02%
Complexity 16450 16450
=========================================
Files 5968 5968
Lines 537086 537086
Branches 65961 65961
=========================================
+ Hits 96819 96821 +2
+ Misses 429347 429343 -4
- Partials 10920 10922 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
DaanHoogland
left a comment
There was a problem hiding this comment.
looks generally good. one point of attention found.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <svg width="52px" height="45px" viewBox="0 0 52 45" version="1.1" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| <svg width="52px" height="45px" viewBox="0 0 52 45" version="1.1" |
Contributor
There was a problem hiding this comment.
bit weary about this line, as I don’t see a change in it, but I guess svg are just xml-texts, so soi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now targetting more files and file types
Also minor change to the markdown lint hook since we only have ".md" files
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Ran
pre-commit run --all-filesHow did you try to break this feature and the system with this change?