nasbackup.sh: verify backup integrity with qemu-img check#12845
Open
jmsperu wants to merge 1 commit intoapache:4.20from
Open
nasbackup.sh: verify backup integrity with qemu-img check#12845jmsperu wants to merge 1 commit intoapache:4.20from
jmsperu wants to merge 1 commit intoapache:4.20from
Conversation
Add verify_backup() that runs qemu-img check on all qcow2 files after backup completes. Catches corrupt or truncated backup files (e.g. from NFS I/O errors or storage full) before reporting success. Applied to both running and stopped VM backup paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify_backup()function that runsqemu-img checkon all qcow2 backup files after backup completesMotivation
Without verification, a backup that was silently corrupted by NFS errors or disk full conditions is reported as successful. The admin only discovers the corruption when attempting to restore — which is the worst possible time.
qemu-img checkis fast (reads metadata only, not full data) and catches structural corruption.Test plan
qemu-img checkpasses in agent log