Remove realhostip references from the code#12856
Draft
vishesh92 wants to merge 1 commit intoapache:mainfrom
Draft
Remove realhostip references from the code#12856vishesh92 wants to merge 1 commit intoapache:mainfrom
vishesh92 wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12856 +/- ##
============================================
+ Coverage 17.95% 18.02% +0.07%
- Complexity 16259 16451 +192
============================================
Files 5954 5968 +14
Lines 534838 537081 +2243
Branches 65423 65959 +536
============================================
+ Hits 96010 96818 +808
- Misses 428053 429342 +1289
- Partials 10775 10921 +146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to remove legacy realhostip domain references across CloudStack (tests, SystemVM packaging/scripts, and management-server logic), and to clear stale configuration values during upgrade.
Changes:
- Replace
*.realhostip.com/realhostip.comreferences in tests and comments with*.example.com/example.com. - Rename/update SystemVM truststore/cert/key filenames from
realhostip.*tosystemvm.*and update related scripts/poms to reference the new names. - Remove legacy “only realhostip supported” warnings and add an upgrade SQL to null out stale
realhostipconfiguration values.
Reviewed changes
Copilot reviewed 13 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/src/test/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtilTest.java | Updates test domain strings away from realhostip. |
| systemvm/pom.xml | Updates quickcloud trustStore filename to systemvm.keystore. |
| systemvm/patch-sysvms.sh | Updates keystore path used when importing JVM cacerts. |
| systemvm/debian/opt/cloud/bin/setup/bootstrap.sh | Updates keystore path used during systemvm bootstrap. |
| systemvm/agent/scripts/config_ssl.sh | Renames default cert/key/keystore filenames used for SSL setup. |
| systemvm/agent/scripts/_run.sh | Updates agent JVM trustStore filename to systemvm.keystore. |
| systemvm/agent/certs/systemvm.keystore | Adds/renames keystore artifact used by SystemVM components. |
| systemvm/agent/certs/systemvm.key | Adds/renames private key artifact used by SystemVM SSL setup. |
| systemvm/agent/certs/systemvm.csr | Adds/renames CSR artifact. |
| systemvm/agent/certs/systemvm.crt | Adds/renames certificate artifact. |
| services/secondary-storage/server/pom.xml | Updates trustStore filename to systemvm.keystore. |
| services/console-proxy/server/pom.xml | Updates excluded CSR filename to systemvm.csr. |
| server/src/test/java/com/cloud/keystore/KeystoreTest.java | Updates hard-coded test domain strings away from realhostip. |
| server/src/main/java/com/cloud/storage/upload/UploadMonitorImpl.java | Removes legacy realhostip fallback/logic and adjusts URL generation behavior. |
| server/src/main/java/com/cloud/storage/download/DownloadMonitorImpl.java | Removes legacy warning tied to realhostip domain/cert expectations. |
| server/src/main/java/com/cloud/server/ConfigurationServerImpl.java | Clears the legacy secstorage.secure.copy.cert default value. |
| engine/schema/src/main/resources/META-INF/db/schema-42210to42300.sql | Clears stale realhostip configuration values during upgrade. |
| .pre-commit-config.yaml | Updates pre-commit allowlist to match the renamed private key filename. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ^services/console-proxy/rdpconsole/src/test/doc/rdp-key\.pem$| | ||
| ^systemvm/agent/certs/localhost\.key$| | ||
| ^systemvm/agent/certs/realhostip\.key$| | ||
| ^systemvm/agent/certs/systemvm\.key$| |
Comment on lines
366
to
+370
| hostname = hostname + "." + _ssvmUrlDomain; | ||
| } else { | ||
| hostname = hostname + ".realhostip.com"; | ||
| logger.warn("SSL copy is enabled but secstorage.ssl.cert.domain is not configured; " | ||
| + "using IP address directly. Configure a wildcard SSL certificate domain for proper HTTPS support."); | ||
| hostname = ipAddress; |
Comment on lines
+55
to
+56
| customPrivKey=$(dirname $0)/certs/systemvm.key | ||
| customPrivCert=$(dirname $0)/certs/systemvm.crt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes references for realhostip.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?