Skip to content

ipmi: Uncensor port on sanitised logs#12990

Open
GaOrtiga wants to merge 1 commit intoapache:mainfrom
scclouds:uncensor_port_IPMI
Open

ipmi: Uncensor port on sanitised logs#12990
GaOrtiga wants to merge 1 commit intoapache:mainfrom
scclouds:uncensor_port_IPMI

Conversation

@GaOrtiga
Copy link
Copy Markdown
Contributor

@GaOrtiga GaOrtiga commented Apr 9, 2026

Description

When using IPMI, the password is censored before being shown in the logs, this censorship, however, filters for the -P parameter, ignoring case. This causes the port to be censored for no reason, as its parameter is -p. This PR uncensors the port while maintaining the censorship on the password, as well as fixes a typo in the method's name.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

The logs changed are used in two places, I checked both instances and verified that the port was no longer censored but the password still was.

How did you try to break this feature and the system with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant