Skip to content

server: allow disk offering selection for volume from snapshot#3246

Merged
yadvr merged 5 commits intoapache:masterfrom
shapeblue:volume_from_snap_offering_support
Jun 25, 2019
Merged

server: allow disk offering selection for volume from snapshot#3246
yadvr merged 5 commits intoapache:masterfrom
shapeblue:volume_from_snap_offering_support

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Mar 28, 2019 •
edited by borisstoyanov
Loading

Description

Problem: Volume created from a snapshot does not show its disk offering.

Root Cause: The volume created from a snapshot of a root disk does not have a disk offering therefore the disk offering of the created volume from the snapshot is empty.

Solution: Refactored createVolume API and extended UI to allow user to select a disk offering while creating a volume using a root disk volume snapshot. For creating volumes using data disk volume snapshot, the disk offering given by the snapshot will be assigned. Disk offering selection in the UI form for volume creation from snapshot is depicted in screenshot below.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Screenshot 2019-06-20 at 12 08 15

How Has This Been Tested?

From UI

@anuragaw @shwstppr
server: allow disk offering selection for volume from snapshot
3906dad 
Snapshots created for ROOT disk does not have disk offering id therefore when volume is created from them resulting volume also doesn't have any disk offering. This change allows selection of disk offering in UI when creating volumes from such snapshots.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr mentioned this pull request Mar 28, 2019
Closed
5 tasks
@borisstoyanov
Copy link
Contributor

borisstoyanov commented Apr 5, 2019

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Apr 5, 2019

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 5, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2683

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Apr 5, 2019

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Apr 5, 2019

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Apr 5, 2019

Trillian test result (tid-3476)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25091 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3476-kvm-centos7.zip
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

borisstoyanov
borisstoyanov approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually checked

@yadvr
Copy link
Member

yadvr commented May 23, 2019

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented May 23, 2019

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented May 23, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2770

@yadvr
Copy link
Member

yadvr commented May 24, 2019

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link

blueorangutan commented May 24, 2019

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented May 24, 2019

Trillian test result (tid-3580)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49407 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3580-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_rvpc_multi_tiers Failure 594.30 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 640.28 test_vpc_redundant.py

@yadvr yadvr added this to the 4.13.0.0 milestone May 27, 2019
@shwstppr
ui: fix for extra diskofferingid param for data disk snaps to volume
bf4e50b 
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
@shwstppr
Copy link
Contributor Author

shwstppr commented Jun 13, 2019

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jun 13, 2019

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jun 13, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2887

@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jun 17, 2019

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jun 17, 2019

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov
borisstoyanov approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, attached test results
test-results.xlsx

@blueorangutan
Copy link

blueorangutan commented Jun 17, 2019

Trillian test result (tid-3693)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29473 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3693-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

shwstppr and others added 3 commits June 20, 2019 16:41
@shwstppr
ui: fix for allowing volume creation without offering
53d006b 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
server: added disk offering size check for volume creation from snapshot
8948344 
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
@shwstppr
ui: revert 53d006b
b76e6c5 
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
@borisstoyanov
Copy link
Contributor

borisstoyanov commented Jun 21, 2019

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jun 21, 2019

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jun 21, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2921

@yadvr
Copy link
Member

yadvr commented Jun 25, 2019

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jun 25, 2019

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr yadvr changed the title [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot server: allow disk offering selection for volume from snapshot Jun 25, 2019
@yadvr
Copy link
Member

yadvr commented Jun 25, 2019

This can be merged as soon as the tests are in and are OK.

@blueorangutan
Copy link

blueorangutan commented Jun 25, 2019

Trillian test result (tid-11)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t11-kvm-centos7.zip
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr merged commit 1b79466 into apache:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@shwstppr @borisstoyanov @blueorangutan @yadvr @nvazquez @anuragaw