Redshift: support wildcard select items with alias#2230
Open
yoabot-droid wants to merge 2 commits intoapache:mainfrom
Open
Redshift: support wildcard select items with alias#2230yoabot-droid wants to merge 2 commits intoapache:mainfrom
yoabot-droid wants to merge 2 commits intoapache:mainfrom
Conversation
…alias)
Redshift allows aliasing wildcard expressions in SELECT, e.g.:
SELECT t.* AS alias FROM t
Previously the parser would fail with:
ParserError("Expected: end of statement, found: AS")
Fix: add opt_alias field to WildcardAdditionalOptions and parse the
optional AS <alias> clause when the dialect supports it.
Adds supports_select_wildcard_with_alias() dialect method, enabled for
RedshiftSqlDialect.
Use all_dialects_where(|d| d.supports_select_wildcard_with_alias()) so tests apply to any dialect that enables the feature, per project conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Redshift supports aliasing wildcard expressions in SELECT statements:
Previously the parser would fail with:
Confirmed working on a live Redshift database.
Solution
opt_alias: Option<Ident>field toWildcardAdditionalOptionssupports_select_wildcard_with_alias()method to theDialecttrait (default:false)RedshiftSqlDialectAS <alias>when the dialect supports itDisplayand span tracking for the new fieldTests
Added regression tests in
tests/sqlparser_common.rsusingall_dialects_where(|d| d.supports_select_wildcard_with_alias()):SELECT t.* AS all_cols FROM tSELECT * AS all_cols FROM t