MSSQL: prevent statement-starting keywords from being consumed as implicit aliases#2233
Open
yoabot-droid wants to merge 1 commit intoapache:mainfrom
Open
MSSQL: prevent statement-starting keywords from being consumed as implicit aliases#2233yoabot-droid wants to merge 1 commit intoapache:mainfrom
yoabot-droid wants to merge 1 commit intoapache:mainfrom
Conversation
…licit aliases In T-SQL multi-statement scripts delimited by newlines, the parser was incorrectly consuming statement-starting keywords (DECLARE, EXEC/EXECUTE, INSERT, UPDATE, DELETE, DROP, CREATE, ALTER, TRUNCATE, PRINT, WHILE, RETURN, THROW, RAISERROR, MERGE) as implicit aliases for the preceding SELECT item or table reference, then failing on the next token. Extended is_select_item_alias() and is_table_factor_alias() in MsSqlDialect to return false for all of these keywords, matching the existing treatment of IF and ELSE. Adds test_tsql_statement_keywords_not_implicit_aliases covering both column and table alias cases across the affected keyword set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In T-SQL multi-statement scripts delimited by newlines, the parser was consuming statement-starting keywords (
DECLARE,EXEC/EXECUTE,INSERT,UPDATE,DELETE,DROP,CREATE,ALTER,TRUNCATE,PRINT,WHILE,RETURN,THROW,RAISERROR,MERGE) as implicit aliases for the precedingSELECTitem or table reference, then failing on the next token.Fix
Extended
is_select_item_alias()andis_table_factor_alias()inMsSqlDialectto returnfalsefor all of these keywords, matching the existing treatment ofIFandELSE.Test
Adds
test_tsql_statement_keywords_not_implicit_aliasescovering column and table alias cases across the full affected keyword set.