chore(frontend): migrate non-dashboard JS/JSX files to TypeScript #37107

rusackas · 2026-01-13T19:12:40Z

Summary

Migrates 15 core JavaScript/JSX files and 11 test files to TypeScript as part of the ongoing frontend modernization effort.

Files Migrated

Utilities & Middleware (3 files)

src/utils/common.js → common.ts
src/middleware/loggerMiddleware.js → loggerMiddleware.ts
src/visualizations/presets/MainPreset.js → MainPreset.ts

Reports (2 files)

src/features/reports/ReportModal/actions.js → actions.ts
src/features/reports/ReportModal/reducer.js → reducer.ts

Explore (6 files)

src/explore/exploreUtils/index.js → index.ts
src/explore/reducers/exploreReducer.js → exploreReducer.ts
src/explore/components/EmbedCodeContent.jsx → EmbedCodeContent.tsx
src/explore/components/ExploreChartHeader/index.jsx → index.tsx
src/explore/components/ExploreViewContainer/index.jsx → index.tsx
src/explore/components/useExploreAdditionalActionsMenu/index.jsx → index.tsx

Chart & Datasource (4 files)

src/components/Chart/chartAction.js → chartAction.ts
src/components/Chart/ChartRenderer.jsx → ChartRenderer.tsx
src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx → DatasourceEditor.tsx
src/components/Datasource/utils/index.js → index.ts

Key Improvements

Added proper TypeScript interfaces for all components and functions
Replaced PropTypes with TypeScript interfaces
Added typed Redux actions and state interfaces
Zero any types used throughout

Testing Instructions

Verify type checking passes: npm run type (note: pre-existing TS6305 errors in packages/plugins are unrelated)
Verify linting passes: npm run lint
Run affected tests: npm run test -- --testPathPattern="(common|logger|MainPreset|ReportModal|exploreUtils|exploreReducer|EmbedCodeContent|ExploreChartHeader|ExploreViewContainer|useExploreAdditionalActionsMenu|chartAction|ChartRenderer|DatasourceEditor)"

Additional Information

This PR excludes dashboard-related files which will be migrated in a separate PR due to their interconnected nature.

🤖 Generated with Claude Code

Migrates 15 core JavaScript/JSX files and 11 test files to TypeScript as part of the ongoing frontend modernization effort. Files migrated: - src/utils/common.js → common.ts - src/middleware/loggerMiddleware.js → loggerMiddleware.ts - src/visualizations/presets/MainPreset.js → MainPreset.ts - src/features/reports/ReportModal/actions.js → actions.ts - src/features/reports/ReportModal/reducer.js → reducer.ts - src/explore/exploreUtils/index.js → index.ts - src/explore/reducers/exploreReducer.js → exploreReducer.ts - src/explore/components/EmbedCodeContent.jsx → EmbedCodeContent.tsx - src/explore/components/ExploreChartHeader/index.jsx → index.tsx - src/explore/components/ExploreViewContainer/index.jsx → index.tsx - src/explore/components/useExploreAdditionalActionsMenu/index.jsx → index.tsx - src/components/Chart/chartAction.js → chartAction.ts - src/components/Chart/ChartRenderer.jsx → ChartRenderer.tsx - src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx → DatasourceEditor.tsx - src/components/Datasource/utils/index.js → index.ts Key improvements: - Added proper TypeScript interfaces for all components and functions - Replaced PropTypes with TypeScript interfaces - Added typed Redux actions and state interfaces - Zero `any` types used throughout Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

superset-frontend/src/components/Chart/ChartRenderer.tsx

superset-frontend/src/components/Chart/chartAction.ts

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

bito-code-review

Code Review Agent Run #55969a

Actionable Suggestions - 5

superset-frontend/src/features/reports/ReportModal/reducer.ts - 1
- Type mismatch in report filtering · Line 55-58
superset-frontend/src/features/reports/ReportModal/actions.ts - 4
- Potential Runtime Error · Line 148-148
- Missing Error Handling · Line 167-175
- Missing Error Handling · Line 184-193
- Success Feedback on Failure · Line 229-235

Additional Suggestions - 3

superset-frontend/src/components/Chart/chartAction.ts - 1
- Incorrect Timezone Handling in Data Age · Line 774-778
  
  The data_age logging mixes local time with UTC, which may produce incorrect age values in non-UTC timezones. Consider using UTC for both dates in the diff calculation.
  Code suggestion
  @@ -775,1 +775,1 @@ - ? extendedDayjs(new Date()).diff( + ? extendedDayjs.utc(new Date()).diff(

superset-frontend/src/features/reports/ReportModal/actions.ts - 2

Inaccurate Error Message · Line 124-124

The error message specifies 'dashboard' but fetchUISpecificReport is used for both dashboard and chart reports, leading to misleading feedback.

Code suggestion

 @@ -120,9 +120,9 @@
-      .catch(() => {
-        dispatch(
-          addDangerToast(
-            t(
-              'There was an issue fetching reports attached to this dashboard.',
-            ),
-          ),
-        );
-      });
+      .catch(() => {
+        dispatch(
-          addDangerToast(
-            t(
-              'There was an issue fetching reports.',
-            ),
-          ),
-        );
-      });

Grammar Error in Message · Line 207-207

The error message uses incorrect grammar; 'active' should be 'activate' to properly indicate the failure to activate or deactivate.

Code suggestion

 @@ -204,7 +204,7 @@
-      .catch(() => {
-        dispatch(
-          addDangerToast(
-            t('We were unable to active or deactivate this report.'),
-          ),
-        );
-      })
+      .catch(() => {
+        dispatch(
-          addDangerToast(
-            t('We were unable to activate or deactivate this report.'),
-          ),
-        );
-      })

Review Details

Files reviewed - 8 · Commit Range: c1b3085..c1b3085
- superset-frontend/src/components/Chart/chartAction.js
- superset-frontend/src/components/Chart/chartAction.ts
- superset-frontend/src/explore/reducers/exploreReducer.js
- superset-frontend/src/explore/reducers/exploreReducer.ts
- superset-frontend/src/features/reports/ReportModal/actions.js
- superset-frontend/src/features/reports/ReportModal/actions.ts
- superset-frontend/src/features/reports/ReportModal/reducer.js
- superset-frontend/src/features/reports/ReportModal/reducer.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

superset-frontend/src/features/reports/ReportModal/reducer.ts

superset-frontend/src/features/reports/ReportModal/actions.ts

Move DELETE_REPORT dispatch and success toast from .finally() to .then() so they only execute on successful deletion, not on failure. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

netlify · 2026-01-13T19:47:17Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`4f743a5`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/69669ce0ed2eec00088bceba
😎 Deploy Preview	https://deploy-preview-37107--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Use vizType (derived from currentFormData) instead of formData.viz_type so drill-to-detail props are correctly enabled/disabled when the user changes visualization type without re-running the query. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

…ask is absent Ensures custom setDataMask handlers work in non-dashboard/embedded contexts. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

- common.ts: wrap return in Boolean() for proper boolean type - logger.test.ts: add dispatch property to MockStore interface - exploreReducer.ts: use flexible ExtendedControlState interface, fix SliceUpdatedAction owners type - ReportModal/actions.ts: use ThunkDispatch for thunk actions, add error handling to addReport - ReportModal/reducer.ts: cast through unknown for dynamic property access Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

bito-code-review

Code Review Agent Run #706562

Actionable Suggestions - 1

superset-frontend/src/explore/reducers/exploreReducer.ts - 1
- Type mismatch in action interface · Line 147-147

Additional Suggestions - 1

superset-frontend/src/explore/reducers/exploreReducer.ts - 1
- Reduced type safety in control state · Line 178-178
  
  Changing ExtendedControlState from extending ControlState to a loose Record reduces type safety, as it no longer guarantees the required properties of ControlState. The reducer casts ExtendedControlState to ControlStateMapping, which expects ControlState objects, potentially allowing invalid control configurations.

Review Details

Files reviewed - 8 · Commit Range: 2230728..234c958
- superset-frontend/src/components/Chart/chartAction.js
- superset-frontend/src/components/Chart/chartAction.ts
- superset-frontend/src/explore/reducers/exploreReducer.js
- superset-frontend/src/explore/reducers/exploreReducer.ts
- superset-frontend/src/features/reports/ReportModal/actions.js
- superset-frontend/src/features/reports/ReportModal/actions.ts
- superset-frontend/src/features/reports/ReportModal/reducer.js
- superset-frontend/src/features/reports/ReportModal/reducer.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-01-13T21:54:56Z

superset-frontend/src/explore/reducers/exploreReducer.ts

+
+interface SliceUpdatedAction {
+  type: typeof actions.SLICE_UPDATED;
+  slice: Omit<Slice, 'owners'> & {


Type mismatch in action interface

The SliceUpdatedAction interface expects owners as Array<{value: number; label: string}>, but the action creator sliceUpdated takes Slice with owners as number[]. This mismatch could cause runtime failures in the reducer handler when mapping owner.value, as the handler assumes owners are objects with value/label properties.

Code suggestion

Check the AI-generated fix before applying

Suggested change

slice: Omit<Slice, 'owners'> & {

slice: Slice & {

Citations

Rule Violated: dev-standard.mdc:16

Code Review Run #706562

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

- actions.ts: add error handling to editReport, guard against empty charts - chartAction.ts: fix RootState type, cast SupersetClient calls, add AnnotationLayerWithOverrides type Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

bito-code-review · 2026-01-13T23:12:35Z

Code Review Agent Run #dcfec9

Actionable Suggestions - 0

Review Details

Files reviewed - 8 · Commit Range: 234c958..3fce4fe
- superset-frontend/src/components/Chart/chartAction.js
- superset-frontend/src/components/Chart/chartAction.ts
- superset-frontend/src/explore/reducers/exploreReducer.js
- superset-frontend/src/explore/reducers/exploreReducer.ts
- superset-frontend/src/features/reports/ReportModal/actions.js
- superset-frontend/src/features/reports/ReportModal/actions.ts
- superset-frontend/src/features/reports/ReportModal/reducer.js
- superset-frontend/src/features/reports/ReportModal/reducer.ts
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

pull-request-size bot added the size/XXL label Jan 13, 2026

dosubot bot added change:frontend Requires changing the frontend frontend:refactor Related to refactoring the frontend labels Jan 13, 2026

codeant-ai-for-open-source bot reviewed Jan 13, 2026

View reviewed changes

apache deleted a comment from codeant-ai-for-open-source bot Jan 13, 2026

apache deleted a comment from bito-code-review bot Jan 13, 2026

fix: remove unused ChartDataResponse interface

45178c8

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

apache deleted a comment from codeant-ai-for-open-source bot Jan 13, 2026

bito-code-review bot reviewed Jan 13, 2026

View reviewed changes

fix(reports): only show success toast when delete succeeds

4f743a5

Move DELETE_REPORT dispatch and success toast from .finally() to .then() so they only execute on successful deletion, not on failure. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

rusackas and others added 3 commits January 13, 2026 12:04

fix(chart): remove unused POST_CHART_FORM_DATA constant

e3ee2bf

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

fix(chart): use setDataMask prop as fallback when actions.updateDataM…

2230728

…ask is absent Ensures custom setDataMask handlers work in non-dashboard/embedded contexts. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

This comment was marked as outdated.

Sign in to view

bito-code-review bot reviewed Jan 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(frontend): migrate non-dashboard JS/JSX files to TypeScript #37107

chore(frontend): migrate non-dashboard JS/JSX files to TypeScript #37107

Uh oh!

rusackas commented Jan 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bito-code-review bot left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jan 13, 2026

Uh oh!

This comment was marked as outdated.

bito-code-review bot left a comment •

edited

Loading

Uh oh!

bito-code-review bot Jan 13, 2026

Uh oh!

bito-code-review bot commented Jan 13, 2026 •

edited

Loading

Code Review Agent Run #dcfec9

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chore(frontend): migrate non-dashboard JS/JSX files to TypeScript #37107

Are you sure you want to change the base?

chore(frontend): migrate non-dashboard JS/JSX files to TypeScript #37107

Uh oh!

Conversation

rusackas commented Jan 13, 2026

Summary

Files Migrated

Key Improvements

Testing Instructions

Additional Information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #55969a

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Jan 13, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

This comment was marked as outdated.

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #706562

Uh oh!

bito-code-review bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

bito-code-review bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #dcfec9

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

bito-code-review bot left a comment •

edited

Loading

bito-code-review bot left a comment •

edited

Loading

bito-code-review bot commented Jan 13, 2026 •

edited

Loading