feat: make event type generic in RequestHandler#18
Merged
astuyve merged 7 commits intoastuyve:mainfrom Mar 26, 2025
Merged
Conversation
|
This is nice. |
Contributor
Author
|
Looks like I forgot to mention @astuyve to request review! |
jm42
reviewed
Mar 26, 2025
src/index.ts
Outdated
Comment on lines
16
to
17
| TEvent = APIGatewayProxyEventV2, | ||
| TResult = void |
There was a problem hiding this comment.
Suggested change
| TEvent = APIGatewayProxyEventV2, | |
| TResult = void | |
| TEvent = LambdaFunctionURLEvent, | |
| TResult = LambdaFunctionURLResult |
Owner
Contributor
Author
|
Yes, fair enough. Note I had to update @types/aws-lambda to bring in the new type alias. Ready for review again @astuyve |
Owner
|
LGTM, thanks! |
Owner
|
Released in 0.6.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds generic type arguments to
streamifyResponse, so that handlers with different event types can be used (not onlyAPIGatewayProxyEventV2).The
eventpayload for a Lambda function can have different types depending on how the function is called. When a function is called using the Invoke API, it could be an entirely arbitrary object.I've also renamed
RequestHandlertoStreamingHandler. This seems more correct to me since an invocation is not necessarily the same as an HTTP request, and is more in line with the naming of theHandlertype in @types/aws-lambda. An exported type alias ofRequestHandler = StreamingHandler<APIGatewayProxyEventV2>is provided for backwards compatibility.Fixes #16