fix npe when mapping insert / delete events.#143
Merged
carlzogh merged 2 commits intoaws:masterfrom Jun 11, 2020
senioroman4uk:fix-new-image-old-image-npe
Merged
fix npe when mapping insert / delete events.#143carlzogh merged 2 commits intoaws:masterfrom senioroman4uk:fix-new-image-old-image-npe
carlzogh merged 2 commits intoaws:masterfrom
senioroman4uk:fix-new-image-old-image-npe
Conversation
carlzogh
reviewed
Jun 8, 2020
Contributor
carlzogh
left a comment
There was a problem hiding this comment.
Awesome, thanks for spotting this and submitting a PR to get it fixed!
...ws/services/lambda/runtime/events/transformers/dynamodb/DynamodbStreamRecordTransformer.java
Show resolved
Hide resolved
...ws/services/lambda/runtime/events/transformers/dynamodb/DynamodbStreamRecordTransformer.java
Show resolved
Hide resolved
...ervices/lambda/runtime/events/transformers/dynamodb/DynamodbStreamRecordTransformerTest.java
Outdated
Show resolved
Hide resolved
...ervices/lambda/runtime/events/transformers/dynamodb/DynamodbStreamRecordTransformerTest.java
Outdated
Show resolved
Hide resolved
Insert event does not have oldImage. Remove event does not have newImage. At this moment library just throws nullPointerException
Contributor
Author
|
hey guys do you have any other suggestions? I would appreciate for this PR to be merged |
Contributor
|
Thanks for your contribution @senioroman4uk ! |
Contributor
Author
|
My pleasure) If you need help with any other issue, let me know |
Contributor
|
@senioroman4uk |
Contributor
Author
|
Super! glad to be of assistance |
raupachz
pushed a commit
to raupachz/aws-lambda-java-libs
that referenced
this pull request
Dec 1, 2020
Insert event does not have oldImage. Remove event does not have newImage. At this moment library just throws nullPointerException Co-authored-by: Carl Zogheib <11421173+carlzogh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insert event does not have oldImage. Remove event does not have newImage. At this moment library just throws nullPointerException
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.