Closed
Conversation
Contributor
|
Has this been tested on the AWS platform? |
Contributor
Author
Yes, LB and API GW were tested, I removed websockets |
Contributor
|
Thanks! @jeromevdl |
carlzogh
reviewed
Jun 2, 2021
Comment on lines
+956
to
+964
| if (headers == null || headers.isEmpty()) { | ||
| this.headers = null; | ||
| return; | ||
| } | ||
|
|
||
| if (this.headers == null) { | ||
| this.headers = new HttpHeaders<>(); | ||
| } | ||
| this.headers.putAll(headers); |
Contributor
There was a problem hiding this comment.
This is a breaking change for consumers using setHeaders and expecting it to override all previous values
Contributor
Author
There was a problem hiding this comment.
Right, we need to remove if (this.headers == null)
parawanderer
added a commit
to parawanderer/aws-lambda-java-libs
that referenced
this pull request
Dec 22, 2021
This solution builds upon @jeromevdl 's solution of PR aws#234 to fix the issue of headers being case sensitive. Fixes @carlzogh 's comment regarding breaking changes in setHeaders.
parawanderer
added a commit
to parawanderer/aws-lambda-java-libs
that referenced
this pull request
Dec 22, 2021
This solution builds upon @jeromevdl 's solution of PR aws#234 to fix the issue of headers being case sensitive. Fixes @carlzogh 's comment regarding breaking changes in setHeaders.
parawanderer
added a commit
to parawanderer/aws-lambda-java-libs
that referenced
this pull request
Dec 22, 2021
This solution builds upon @jeromevdl 's solution of PR aws#234 to fix the issue of headers being case sensitive. Fixes @carlzogh 's comment regarding breaking changes in setHeaders.
Contributor
|
Closing, replaced with #298 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #220
Description of changes: Using TreeMap (and CASE_INSENSITIVE_ORDER initialisation) within a custom Header object.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.