Added AWS provider badge#87
Added AWS provider badge#87leandrodamascena wants to merge 1 commit intoaws-powertools:developfrom leandrodamascena:develop
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #87 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 474 474
Branches 42 42
=========================================
Hits 474 474 Continue to review full report at Codecov.
|
|
Hey @leandrodamascena - Firstly, thanks for the contribution :) Could you expand on why you think this is necessary? It's the first time I'm seeing a badge like this, so any additional info you can share that would be helpful :) |
|
Hi @heitorlessa. It's a pleasure starting to contribute with this repository. I use this tool professionally since I discovered it (2 or 3 months ago) and now I instrument my lambda functions with less code and more efficiency.. Reading the other issues, I think that I can contribute with #30. About this badge, hmm, I maintain some small projects (aws related) [1] and I think that it's good to show to users which cloud providers these tools covers, even it is hosted by awslabs. It was my though about this PR. Feel free to reject this PR, it really was a small contribution haha :) Btw, I watched your Brazilian meetup yesterday and had some new insights about Serverless, thank you for share your knowledge with us :D [1] - https://github.com/Cloud-Architects/cloudiscovery / https://github.com/mingrammer/diagrams |
This is AWESOME to hear ;)
Ah, that makes sense now. As we call out this is specifically tied and optimized to AWS Lambda, I think it'd be redundant to add this badge, so I'll close this PR. Nevertheless, I'd love if you could share your thoughts and contributions to #30 too - We're primarily doing some clean ups and hearing customers on what other languages should we work next, but I expect to start working on additional utilities for Python sometime in August ;) |
Description of changes:
Added AWS provider badge to identify cloud provider.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.