This repository was archived by the owner on Oct 14, 2022. It is now read-only.
Open
Conversation
- Tests need to do an assertion - t.ok & t.same don’t exist anymore
… base requires moment so the upgrade required to add moment as a dependency
Contributor
Author
|
Note: The tests pass through on my machine but occasionally they fail. Maybe run again on travis can fix them? |
Member
|
Something is consistently failing with logins. I haven't been able to isolate it but it looks like races -- maybe something got screwed up with promises? |
Contributor
Author
|
@pfrazee the tests run smooth here. would you mind to triangulate which commit broke it? |
Member
|
Sorry Im a bit tied up atm, but this is on my todo list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several of the dependencies of hashbase have been updated. In this PR I updated the dependencies that were easy to update. I didn't update
leveldbandnodemailerbecause those dependencies would involve (significantly) more effort.