Open
Conversation
| @@ -65,9 +65,7 @@ def values_in_col(cursor, table_name, print_out=True): | |||
| """ | |||
| cursor.execute('PRAGMA TABLE_INFO({})'.format(table_name)) | |||
| info = cursor.fetchall() | |||
Author
There was a problem hiding this comment.
Function values_in_col refactored with the following changes:
- Replace dict() with {}
- Convert for loop into dictionary comprehension
| @@ -6,11 +6,7 @@ | |||
| import os | |||
|
|
|||
| def find_files(substring, path): | |||
Author
There was a problem hiding this comment.
Function find_files refactored with the following changes:
- Convert for loop into list comprehension
- Inline variable that is only used once
| @@ -16,11 +16,7 @@ def likelihood_poisson(x, lam): | |||
| Poisson distribution | |||
|
|
|||
| """ | |||
Author
There was a problem hiding this comment.
Function likelihood_poisson refactored with the following changes:
- Replace if statement with if expression
- Inline variable that is only used once
| @@ -6,8 +6,7 @@ def comp_theta_mle(d): | |||
| dataset for a Rayleigh distribution. | |||
|
|
|||
| """ | |||
Author
There was a problem hiding this comment.
Function comp_theta_mle refactored with the following changes:
- Inline variable that is only used once
- Replace unneeded comprehension with generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
To manually merge these changes, make sure you're on the
masterbranch, then run:See our documentation for configuring or disabling Sourcery.