chore: apply security best practices for CI#7066
Merged
mohammed90 merged 4 commits intomasterfrom Jun 16, 2025
Merged
Conversation
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
Member
Author
|
Good enough for me for now. It resolves many concerns. We can audit outbound calls here: https://app.stepsecurity.io/github/caddyserver/actions/runs. Resolving the scorecard generation for PRs can be tackled later. |
mholt
approved these changes
Jun 16, 2025
Member
mholt
left a comment
There was a problem hiding this comment.
As long as the jobs are succeeding, I have no real way of knowing if this is wrong/right, haha, so let's try it out, and we'll keep iterating on it! 🕺 Thanks @mohammed90 !
1 task
mohammed90
added a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
* chore: apply security best practices for CI Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com> * remove redundant codeql job Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com> * run scorecard flow on PRs Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com> --------- Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pay close attention here to ensure nothing will break.
Supersedes / Closes #7065