Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements standardized error definitions to allow clients to check for specific error conditions using errors.Is(). It addresses issue #365 by defining two exported error variables (ErrCertNotAvailable and ErrCertTimeout) and updating error returns throughout the handshake code to use these standardized errors.
Changes:
- Added two exported error variables (
ErrCertNotAvailableandErrCertTimeout) for standardized error checking - Updated multiple error return statements to wrap these errors using
fmt.Errorfwith%w - Added test coverage to verify
ErrCertNotAvailablecan be detected usingerrors.Is()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| handshake.go | Defines two new error variables and updates 5 error return locations to use them with proper error wrapping |
| handshake_test.go | Adds import for errors package and adds test assertion to verify ErrCertNotAvailable is properly detectable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #365