Fix unique index + MutTxId::insert not un-deleteting#2156
Merged
Conversation
ec114e7 to
8d3067d
Compare
gefjon
approved these changes
Jan 21, 2025
Contributor
gefjon
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the new test. Once you get CI happy, this is good to merge as far as I'm concerned.
gefjon
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #2134.
The resolution was a fix to a silly bug where we did not un-delete in case of a unique index.
Also fixes an issue in
find_same_row_via_unique_indexwhere it didn't check row equality for the found pointer.API and ABI breaking changes
None.
Expected complexity level and risk
1
Testing
A regression test is added.
Also ran the repro in the issue: