Switch build tool from tsup to tsdown#50
Open
kingsword09 wants to merge 1 commit intocloudflare:mainfrom
Open
Conversation
Member
|
@threepointone What is the best practice here in your opinion? |
Collaborator
|
tsup's fine in that it's not broken, but I'll investigate tsdown (and use it in a couple of repos too if it's straightforward). but for now it's fine, even agents uses tsup atm. |
Collaborator
|
oh this is a PR. lemme verify and come back it. |
Collaborator
|
I tested tsdown, it's pretty good, faster. We moved agents to it. We could land this one. |
Member
|
Update: We'd like to land this but @threepointone mentioned something about a dependency version conflict with vitest-pool-workers? Maybe he can explain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsup is not actively maintained anymore. Official documentation also recommends migration to tsdown.