docs: add deno server example to the README#57
Merged
kentonv merged 3 commits intocloudflare:mainfrom Sep 27, 2025
Merged
Conversation
Contributor
Author
|
Maybe the request should be updated instead if this function really doesn't accept headers // If you are accepting WebSockets, then you might as well accept cross-origin HTTP, since
// WebSockets always permit cross-origin request anyway. But, see security considerations
// for further discussion.
const headers = new Headers(req.headers);
headers.set("Access-Control-Allow-Origin", "*");
const updatedReq = new Request(req, { headers });
return newHttpBatchRpcResponse(updatedReq, new MyApiImpl()); |
kentonv
reviewed
Sep 25, 2025
Co-authored-by: Kenton Varda <kenton@cloudflare.com>
Contributor
Author
|
I updated the code as you suggested |
Member
|
Thank you! |
Contributor
Author
|
Thank you as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if I uncomment headers it gives this type error