fix(dropdown): improve external link detection #49
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
http://and//(protocol-relative URLs)https://links opened in a new tabProblem
The
DropdownMenuItemcomponent's external link detection only checked forhttps://:This meant
http://links and protocol-relative URLs (//example.com) were incorrectly treated as internal links and routed throughLinkComponentinstead of opening in a new tab.Solution
Use a regex to match all external URL patterns:
https://example.comhttp://example.com//example.com/dashboard